Add notification when move connectable #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Slimane AMAR <[email protected]>
SlimaneAmar
force-pushed
the
add_notification_when_move_connectable
branch
from
92ef6f3 to
1fd93ea
Compare
FranckLecuyer
requested changes
Oct 3, 2024
|
|
||
| @Override | ||
| public String toString() { | ||
| return "NodeTopologyPoint(" + |
There was a problem hiding this comment.
BusTopologyPoint (same error in powsybl-core ...)
| public void moveConnectable(int node, String voltageLevelId) { | ||
| TopologyPoint oldTopologyPoint = TerminalImpl.this.getTopologyPoint(); | ||
| super.moveConnectable(node, voltageLevelId); | ||
| index.notifyUpdate(connectable, "moveConnectable", oldTopologyPoint, TerminalImpl.this.getTopologyPoint()); |
There was a problem hiding this comment.
attribute name "moveConnectable" is not the same as the one in powsybl-core ... (where it is : "terminal" + side)
notifyUpdate("terminal" + (iSide + 1), oldTopologyPoint, terminalExt.getTopologyPoint());
| public void moveConnectable(String busId, boolean connected) { | ||
| TopologyPoint oldTopologyPoint = TerminalImpl.this.getTopologyPoint(); | ||
| super.moveConnectable(busId, connected); | ||
| index.notifyUpdate(connectable, "moveConnectable", oldTopologyPoint, TerminalImpl.this.getTopologyPoint()); |
FranckLecuyer
requested changes
Oct 4, 2024
| public void moveConnectable(int node, String voltageLevelId) { | ||
| TopologyPoint oldTopologyPoint = TerminalImpl.this.getTopologyPoint(); | ||
| super.moveConnectable(node, voltageLevelId); | ||
| index.notifyUpdate(connectable, "terminal" + getSide(), oldTopologyPoint, TerminalImpl.this.getTopologyPoint()); |
| public void moveConnectable(String busId, boolean connected) { | ||
| TopologyPoint oldTopologyPoint = TerminalImpl.this.getTopologyPoint(); | ||
| super.moveConnectable(busId, connected); | ||
| index.notifyUpdate(connectable, "terminal" + getSide(), oldTopologyPoint, TerminalImpl.this.getTopologyPoint()); |
Signed-off-by: Slimane AMAR <[email protected]>
SlimaneAmar
force-pushed
the
add_notification_when_move_connectable
branch
from
74e5c8b to
2016ca3
Compare
Signed-off-by: Slimane AMAR <[email protected]>
FranckLecuyer
approved these changes
Oct 4, 2024
… into add_notification_when_move_connectable
|
antoinebhs
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior?
When we move a connectable no notification sent
What is the new behavior (if this is a feature change)?
When we move a connectable a notification is sent
Does this PR introduce a breaking change or deprecate an API?