Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove DanglingLineBoundaryImpl as it is a copy from powsybl #481

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

EtienneLt
Copy link
Contributor

@EtienneLt EtienneLt commented Nov 28, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
yes #482

What kind of change does this PR introduce?
code cleaning

What is the current behavior?

What is the new behavior (if this is a feature change)?
remove a copied class

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

Copy link

sonarcloud bot commented Nov 28, 2024

Copy link
Collaborator

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK

@EtienneLt EtienneLt merged commit 169f4dd into main Nov 28, 2024
4 checks passed
@EtienneLt EtienneLt deleted the remove-copied-class branch November 28, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants