implement remove for danglingLines #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AbdelHedhili <[email protected]>
AbdelHedhili
changed the title
Signed-off-by: AbdelHedhili <[email protected]>
geofjamg
reviewed
Mar 3, 2020
network-store-client/src/main/java/com/powsybl/network/store/client/NetworkObjectIndex.java
Show resolved
Hide resolved
geofjamg
reviewed
Mar 3, 2020
...-client/src/main/java/com/powsybl/network/store/client/PreloadingRestNetworkStoreClient.java
Outdated
Show resolved
Hide resolved
geofjamg
reviewed
Mar 3, 2020
| @@ -462,6 +463,14 @@ public int getDanglingLineCount(UUID networkUuid) { | |||
| return client.getDanglingLineCount(networkUuid); | |||
| } | |||
|
|
|||
| @Override | |||
| public void removeDanglingLine(UUID networkUuid, String danglingLineId) { | |||
| List<Resource<DanglingLineAttributes>> dlToRemove = | |||
There was a problem hiding this comment.
We might have performance issue with this. We can keep it as it is but maybe we will need to change to resources storage data structure for fast removal.
Signed-off-by: AbdelHedhili <[email protected]>
AbdelHedhili
changed the title
AbdelHedhili
force-pushed
the
implement_remove_DL
branch
from
34b52d2 to
498076c
Compare
Signed-off-by: AbdelHedhili <[email protected]>
AbdelHedhili
force-pushed
the
implement_remove_DL
branch
from
498076c to
4cc5016
Compare
Signed-off-by: AbdelHedhili <[email protected]>
Signed-off-by: AbdelHedhili <[email protected]>
Signed-off-by: AbdelHedhili <[email protected]>
AbdelHedhili
changed the title
geofjamg
approved these changes
Mar 25, 2020
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AbdelHedhili [email protected]
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#29 implement remove for danglingLines