Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Knitro ac solver #1106

Closed
wants to merge 116 commits into from
Closed

[WIP] Knitro ac solver #1106

wants to merge 116 commits into from

Conversation

jeanneArchambault
Copy link
Contributor

@jeanneArchambault jeanneArchambault commented Oct 21, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

p-arvy and others added 30 commits April 22, 2024 15:09
@p-arvy
Add interface to use Knitro as AcSolver.
ab0944b 
Signed-off-by: parvy <[email protected]>
@p-arvy
Merge branch 'refs/heads/main' into add_knitro_ac_solver_for_inner_loop
42a8f7d
@p-arvy
Comment useless test (for now).
1669650 
Signed-off-by: p-arvy <[email protected]>
@p-arvy
Merge branch 'refs/heads/main' into knitro-ac-solver
b311900
@jeanneArchambault
1st Knitro model + solver for basic load flow calculations (no outer …
57ace4b 
…loop)
@jeanneArchambault
TU critère d'arrêt Knitro
7030b83 
default value + change value critère d'arrêt
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
TU default convergence in knitro = default convergence in NR
0983f0c 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
TU Eurostag + 4bus with Condenser
1423125 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
TU value Voltage mode init
42ea8ff 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Get acStatus from knitroStatus
18f74cf 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
LOGGER Info + debug + trace
00ddbd3 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Modif LOGGER
fdcd70f 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Intilisation des varaibles dans solveur Knitro + Commentaire du param…
bc3ea54 
…ètre d'init dans le solveur Knitro

Le paramètre du solverKnitro qui décrit quel type d'initialisation est faite pour V et Theta a été passé en commentaire (et également dans le tests correspondants) car à priori inutile vu que ce n'est pas non plus un attribut de newton raphson
@jeanneArchambault
Comment in English
b027742 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Min and max voltage default values
b975316 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Création d'une arbo similaire à celle de NR mais pour Knitro, pour le…
7c0a5bc 
… paramètre stopping criteria + TU associés (modif de paramètre de convergence dans Knitro)

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
TU 2 bus Knitro
9adf7d2 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Parametrize initial state
7843f16 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Set voltage lower and upper bounds as Knitro parameters + TU
04171ea 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Renaming previous OLF parameter minRealisticVoltage to minRealisticVo…
8c04821 
…ltageNewtonRaphson

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
TU get and set voltage bounds
fa34f92 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Cleaning + adapting OLF TU (include new knitro parameters)
04fd84a 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Modify how lower and upper bounds are set to make it robust to having…
60b249b 
… other variables (then V and theta)

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Changing how constraints are added to make it robust to adding other …
8f29df6 
…variables

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
CANCEL AND REPLACE previous commit (simpler way)
d9c86fd 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Adding Zero_Phi constraints for Non impendant Lines + passing only No…
8abe534 
…n linear cts to callback function

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Transform the original Jacobian into the jacobian of only non linear …
5e460d2 
…constraints

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Matlab load network
8054c73 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Test matpower (IEEE14)
390a3e5 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Test matpower (IEEE14)
ee458b2 
Signed-off-by: jarchambault <[email protected]>
jeandemanged
jeandemanged requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, looks promising, I need to grab a knitro license ;)

jeanneArchambault
jeanneArchambault commented Oct 22, 2024
View reviewed changes
@jeanneArchambault
Change UpdateNetwork parameters (only one common parameters in OLF pa…
25e7796 
…rameters)

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Knitro lower and upper bounds parameters
fc79b94 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Delete unnecessary class AbstractNonLinearExternalSolver
ec83558 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Update KnitroStatus class
4040811 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
When KNException is thrown, should not return an acStatus
60feb12 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Merge branch 'main' into knitro-ac-solver
b959fc7
@jeanneArchambault
Modify knitro solver factory structure to fit into ac solver factory …
baf9641 
…structure

Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Modify pom to reach for the update of ac solver factory
480eb64 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Revert "Modify pom to reach for the update of ac solver factory"
f0876f5 
This reverts commit 480eb64.
@jeanneArchambault
Revert "Modify knitro solver factory structure to fit into ac solver …
92c2c15 
…factory structure"

This reverts commit baf9641.
@jeanneArchambault
Fix
a82aa3b 
Signed-off-by: jarchambault <[email protected]>
@jeanneArchambault
Oubli de test dans Knitro
592e4d8 
Signed-off-by: jarchambault <[email protected]>
@jeandemanged
Copy link
Member

Closing: addressed by #1107 and powsybl/powsybl-open-loadflow-knitro-solver#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeandemanged jeandemanged jeandemanged requested changes

@p-arvy p-arvy Awaiting requested review from p-arvy

Assignees
No one assigned
Labels
None yet
Projects
Release 12/2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeanneArchambault @jeandemanged @p-arvy