-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geographical coordinates to network for NAD drawing and use GeographicalLayout #102
Conversation
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
…/powsybl-single-line-diagram-server into generate_NAD_coordinates
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
src/main/java/com/powsybl/sld/server/NetworkAreaDiagramService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/sld/server/NetworkAreaDiagramService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/sld/server/NetworkAreaDiagramService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/sld/server/NetworkAreaDiagramService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/sld/server/NetworkAreaDiagramService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
src/main/java/com/powsybl/sld/server/NetworkAreaDiagramService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/nad/build/iidm/VoltageLevelFilter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: maissa SOUISSI <[email protected]>
Quality Gate failedFailed conditions |
//List of selected voltageLevels with depth | ||
VoltageLevelFilter vlFilter = VoltageLevelFilter.createVoltageLevelsDepthFilter(network, existingVLIds, depth); | ||
//get voltage levels' positions on depth+1 to be able to locate lines on depth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//List of selected voltageLevels with depth | |
VoltageLevelFilter vlFilter = VoltageLevelFilter.createVoltageLevelsDepthFilter(network, existingVLIds, depth); | |
//get voltage levels' positions on depth+1 to be able to locate lines on depth | |
//List of selected voltageLevels with depth N | |
VoltageLevelFilter vlFilter = VoltageLevelFilter.createVoltageLevelsDepthFilter(network, existingVLIds, depth); | |
//get voltage levels' positions on depth N+1 to be able to locate lines on depth N |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code coverage is low on VoltageLevelFIlter class. We copied it temporarily from powsybl-diagram. It will be removed at next powsybl update. Ok to merge like this.
Please check if the PR fulfills these requirements
What is the current behavior?
Substations' positions extensions are not filled and the NAD is draw with the ForceLayout algorithm.
What is the new behavior (if this is a feature change)?
If substations' positions are not filled in the network, we retrieve the positions from the geo-data-server and we add them as extensions of the substations of the network.
We use the GeographicalLayout to draw the NAD.