Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geographical coordinates to network for NAD drawing and use GeographicalLayout #102

Merged
merged 17 commits into from
Jun 21, 2024

Conversation

souissimai
Copy link
Contributor

@souissimai souissimai commented Jun 8, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?
Substations' positions extensions are not filled and the NAD is draw with the ForceLayout algorithm.

What is the new behavior (if this is a feature change)?
If substations' positions are not filled in the network, we retrieve the positions from the geo-data-server and we add them as extensions of the substations of the network.
We use the GeographicalLayout to draw the NAD.

Signed-off-by: maissa SOUISSI <[email protected]>
pom.xml Outdated Show resolved Hide resolved
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
@souissimai souissimai requested a review from etiennehomer June 17, 2024 12:57
Signed-off-by: maissa SOUISSI <[email protected]>
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
73.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Comment on lines +65 to +67
//List of selected voltageLevels with depth
VoltageLevelFilter vlFilter = VoltageLevelFilter.createVoltageLevelsDepthFilter(network, existingVLIds, depth);
//get voltage levels' positions on depth+1 to be able to locate lines on depth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//List of selected voltageLevels with depth
VoltageLevelFilter vlFilter = VoltageLevelFilter.createVoltageLevelsDepthFilter(network, existingVLIds, depth);
//get voltage levels' positions on depth+1 to be able to locate lines on depth
//List of selected voltageLevels with depth N
VoltageLevelFilter vlFilter = VoltageLevelFilter.createVoltageLevelsDepthFilter(network, existingVLIds, depth);
//get voltage levels' positions on depth N+1 to be able to locate lines on depth N

Copy link
Contributor

@etiennehomer etiennehomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code coverage is low on VoltageLevelFIlter class. We copied it temporarily from powsybl-diagram. It will be removed at next powsybl update. Ok to merge like this.

@etiennehomer etiennehomer changed the title add coordinates to display NAD properly add geographical coordinates to NAD display Jun 21, 2024
@etiennehomer etiennehomer changed the title add geographical coordinates to NAD display Add geographical coordinates to network for NAD drawing and use GeographicalLayout Jun 21, 2024
@flo-dup flo-dup merged commit aeff6e7 into main Jun 21, 2024
3 of 4 checks passed
@flo-dup flo-dup deleted the generate_NAD_coordinates branch June 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants