Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight bus / line / transformer when limit exceed #113

Closed
wants to merge 6 commits into from

Conversation

jamal-khey
Copy link
Contributor

@jamal-khey jamal-khey commented Sep 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
This PR introduces a new style provider that highlights limit violations by adding a CSS class. These classes can be overridden to add animations to specific elements in the diagram.

What is the current behavior?
Limit violations are not displayed

What is the new behavior (if this is a feature change)?
The new behavior allows for the highlighting of limit violations in the diagram by applying specific CSS classes. This enables visual differentiation of elements that exceed defined limits, and users can customize these classes to incorporate animations for enhanced visual feedback.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

What changes might users need to make in their application due to this PR? (migration steps)
Users may need to update their CSS to include the new classes introduced by this PR for highlighting limit violations.
new css classes are:
sld-overload sld-vl-overvoltage sld-vl-undervoltage

Other information:
CI fail because this PR depend on add limit violation highlight

@jamal-khey jamal-khey changed the title High light bus / line / transformer when limit exceed Highlight bus / line / transformer when limit exceed Sep 24, 2024
@jamal-khey jamal-khey self-assigned this Sep 24, 2024
@jamal-khey jamal-khey requested a review from So-Fras September 24, 2024 11:10
@jamal-khey
Copy link
Contributor Author

this PR is not needed any more, change have been done in #120

@jamal-khey jamal-khey closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant