Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change symbol of invalid values #118

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

klesaulnier
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Feature

What is the current behavior?
When an invalid value is displayed (ex: NaN), an empty space is displayed

What is the new behavior (if this is a feature change)?
When an invalid value is displayed (ex: NaN), a specific character is displayed, the same used for SLD

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: LE SAULNIER Kevin <[email protected]>
Copy link
Contributor

@EstherDarkish EstherDarkish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code OK test OK

Copy link

@antoinebhs antoinebhs merged commit 3093e00 into main Oct 18, 2024
4 checks passed
@antoinebhs antoinebhs deleted the change-invalid-value-symbol branch October 18, 2024 13:02
@jamal-khey jamal-khey mentioned this pull request Nov 14, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants