Add bus id in SLD legend #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2024 09:57
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
added 2 commits
November 15, 2024 09:07
Signed-off-by: LE SAULNIER Kevin <[email protected]>
sBouzols
reviewed
Nov 15, 2024
| @@ -0,0 +1,31 @@ | |||
| package com.powsybl.sld.server; | |||
|
sBouzols
reviewed
Nov 15, 2024
| @@ -32,7 +29,7 @@ | |||
| /** | |||
| * @author Ben Daamer ahmed<ahmed.bendaamer at rte-france.com> | |||
| */ | |||
| public class PositionDiagramLabelProvider extends DefaultLabelProvider { | |||
| public class PositionDiagramLabelProvider extends CommonLabelProvider { | |||
There was a problem hiding this comment.
De we need this ? because we call svgParameters.setBusesLegendAdded(false); when we use this PositionDiagramLabelProvider, which will mask BusesLegend ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
Returned SVG legend does not contain bus id
What is the new behavior (if this is a feature change)?
Returned SVG legend does contain bus id
Does this PR introduce a breaking change or deprecate an API?