Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hack when creating and deleting reports #66

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Remove hack when creating and deleting reports #66

merged 4 commits into from
Sep 24, 2024

Conversation

ayolab
Copy link
Contributor

@ayolab ayolab commented Sep 6, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

TheMaskedTurtle
TheMaskedTurtle approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@TheMaskedTurtle TheMaskedTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait for the release with springboot to not block it but then ok !

@ayolab
Fix tests
d19c781 
Signed-off-by: Ayoub LABIDI <[email protected]>
@dbraquart dbraquart self-requested a review September 12, 2024 16:11
dbraquart
dbraquart reviewed Sep 12, 2024
View reviewed changes
Copy link

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: OK
tests:on going

Note: When I upgrade voltage-init-server to use this PR, I have 2 compilation errors ! I had to fix them to run the server. And I also had a test failure (testStop).

@ayolab
Merge branch main
b1919fa 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab
Requested changes
89807f1 
Signed-off-by: Ayoub LABIDI <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ayolab ayolab merged commit 42cbc3e into main Sep 24, 2024
4 checks passed
@ayolab ayolab deleted the ayolab/remove-hack-when-creating-and-deleting-reports branch September 24, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbraquart dbraquart dbraquart left review comments

@TheMaskedTurtle TheMaskedTurtle TheMaskedTurtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayolab @TheMaskedTurtle @dbraquart