Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: tooling upgrade #156

Merged
merged 2 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/ci-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:
# Checkout the code in the pull request
- name: 'Checkout source code'
uses: actions/checkout@v3
uses: actions/checkout@v4

# Install Volta to enforce proper node and package manager versions
- name: 'Install Volta'
Expand All @@ -23,7 +23,7 @@ jobs:
# Cache node_modules to speed up the process
- name: 'Restore node_modules cache'
id: cache-npm
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: node_modules
key: npm-${{ hashFiles('**/package-lock.json') }}
Expand All @@ -48,10 +48,11 @@ jobs:
- name: 'LWC unit tests'
run: npm run test:coverage

# Upload LWC code coverage data
# Upload code coverage data
- name: 'Upload code coverage for LWC to Codecov.io'
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: LWC

scratch-org-tests:
Expand All @@ -61,7 +62,7 @@ jobs:
steps:
# Checkout the code in the pull request
- name: 'Checkout source code'
uses: actions/checkout@v3
uses: actions/checkout@v4

# Install Salesforce CLI
- name: 'Install Salesforce CLI'
Expand Down Expand Up @@ -100,8 +101,9 @@ jobs:

# Upload Apex code coverage data
- name: 'Upload code coverage for Apex to Codecov.io'
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: Apex

# Housekeeping
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
# Checkout the code in the pull request
- name: 'Checkout source code'
uses: actions/checkout@v3
uses: actions/checkout@v4

# Install Volta to enforce proper node and package manager versions
- name: 'Install Volta'
Expand All @@ -24,7 +24,7 @@ jobs:
# Cache node_modules to speed up the process
- name: 'Restore node_modules cache'
id: cache-npm
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: node_modules
key: npm-${{ hashFiles('**/package-lock.json') }}
Expand All @@ -51,8 +51,9 @@ jobs:

# Upload LWC code coverage data
- name: 'Upload code coverage for LWC to Codecov.io'
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: LWC

scratch-org-tests:
Expand All @@ -61,7 +62,7 @@ jobs:
steps:
# Checkout the code in the pull request
- name: 'Checkout source code'
uses: actions/checkout@v3
uses: actions/checkout@v4

# Install Salesforce CLI
- name: 'Install Salesforce CLI'
Expand Down Expand Up @@ -94,8 +95,9 @@ jobs:

# Upload Apex code coverage data
- name: 'Upload code coverage for Apex to Codecov.io'
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: Apex

# Housekeeping
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ Here's how you can retrieve recent records and set them as default search result
```

> [!NOTE]
> `initLookupDefaultResults()` is called in two places because the wire could load before the lookup is rendered.
> The `initLookupDefaultResults()` function is called in two places because the wire could load before the lookup is rendered.

### Saving form state when creating new records (optional)

Expand Down
Loading