PowerVS: Support newly added regions #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @hamzy! It looks like this is your first PR to ppc64le-cloud/powervs-utils 🎉 |
ppc64le-cloud-bot
added
the
size/XS
mkumatag
requested changes
Jan 5, 2024
There was a problem hiding this comment.
As discussed lets add tests and also entries in the
Line 48 in bc42a58
hamzy
force-pushed
the
PowerVS-add-new-zones
branch
from
07e3fb6 to
a306ba5
Compare
ppc64le-cloud-bot
added
size/M
hamzy
force-pushed
the
PowerVS-add-new-zones
branch
from
a306ba5 to
1966848
Compare
There are a bunch of new regions added to PowerVS.
hamzy
force-pushed
the
PowerVS-add-new-zones
branch
from
1966848 to
1f17696
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hamzy, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of new regions added to PowerVS.