Merge functionality with IPI #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppc64le-cloud-bot
added
the
size/M
hamzy
force-pushed
the
Add-IPI-region-functionality
branch
3 times, most recently
from
22e5264 to
7130f61
Compare
mkumatag
requested changes
Jan 23, 2024
hamzy
force-pushed
the
Add-IPI-region-functionality
branch
2 times, most recently
from
a5682fc to
932869b
Compare
mkumatag
requested changes
Jan 25, 2024
The IPI installer has a file (pkg/types/powervs/powervs_regions.go) which contains similiar data and functions. We should merge the two and then use this library in IPI.
hamzy
force-pushed
the
Add-IPI-region-functionality
branch
from
932869b to
c431c89
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hamzy, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPI installer has a file (pkg/types/powervs/powervs_regions.go) which contains similiar data and functions. We should merge the two and then use this library in IPI.