-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerVS: Add an only IPI regions list #9
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hamzy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
In order for the IPI installer to be able to use this module, it needs the ability to have the list of regions to only include supported regions.
4bf16b5
to
558e938
Compare
/hold cancel |
/assign @mkumatag |
I looks like IPI will have to live with updating the same code in two different repos instead of using a module. |
I don't see any better way, @Karthik-K-N @dharaneeshvrd if you have any better idea for this? |
This PR does provide a way to solve the problem. It also effects the code minimally without altering every API used. |
But I see repeated code there, need find a way to reduce that. |
Hrm, when you force push a new version, you cannot reopen the PR. How weird. |
In order for the IPI installer to be able to use this module, it needs the ability to have the list of regions to only include supported regions.