Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerVS: Add an only IPI regions list #9

Closed
wants to merge 1 commit into from

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Jan 27, 2024

In order for the IPI installer to be able to use this module, it needs the ability to have the list of regions to only include supported regions.

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hamzy
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2024
@hamzy
Copy link
Contributor Author

hamzy commented Jan 27, 2024

/hold

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2024
In order for the IPI installer to be able to use this module, it needs the ability to have the list of regions to only include supported regions.
@hamzy hamzy force-pushed the PowerVS-Only-support-PER branch from 4bf16b5 to 558e938 Compare January 27, 2024 12:11
@ppc64le-cloud-bot ppc64le-cloud-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 27, 2024
@hamzy
Copy link
Contributor Author

hamzy commented Jan 27, 2024

/hold cancel

@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2024
@hamzy
Copy link
Contributor Author

hamzy commented Jan 27, 2024

/assign @mkumatag

@hamzy
Copy link
Contributor Author

hamzy commented Feb 6, 2024

I looks like IPI will have to live with updating the same code in two different repos instead of using a module.

@hamzy hamzy closed this Feb 6, 2024
@mkumatag
Copy link
Member

mkumatag commented Feb 7, 2024

I looks like IPI will have to live with updating the same code in two different repos instead of using a module.

I don't see any better way, @Karthik-K-N @dharaneeshvrd if you have any better idea for this?

@hamzy
Copy link
Contributor Author

hamzy commented Feb 7, 2024

This PR does provide a way to solve the problem. It also effects the code minimally without altering every API used.

@mkumatag
Copy link
Member

mkumatag commented Feb 7, 2024

This PR does provide a way to solve the problem. It also effects the code minimally without altering every API used.

But I see repeated code there, need find a way to reduce that.

@hamzy
Copy link
Contributor Author

hamzy commented Feb 7, 2024

Hrm, when you force push a new version, you cannot reopen the PR. How weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants