Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the homebrew tap version at time of new release #675

Closed
wants to merge 2 commits into from
Closed

Bump the homebrew tap version at time of new release #675

wants to merge 2 commits into from

Conversation

carmal891
Copy link
Contributor

Addresses issue #667 using action https://github.com/dawidd6/action-homebrew-bump-formula?tab=readme-ov-file

  • Creates a PR to update the homebrew tap (ppc64le-cloud/homebrew-pvsadm) against each platform dependent formula (linux_amd64, darwin_arm64, darwin_amd64) with latest release version when a new release is made on this repository

Note edge cases

  1. Will not create PR on tap if already existing open PRs exist
  2. Will not create PR on tap if existing version is already higher (v0.1.18 -> v0.1.17 not possible)

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carmal891
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot
Copy link
Contributor

Welcome @carmal891! It looks like this is your first PR to ppc64le-cloud/pvsadm 🎉

@ppc64le-cloud-bot ppc64le-cloud-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 23, 2024
@ppc64le-cloud-bot
Copy link
Contributor

Hi @carmal891. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2024
@carmal891
Copy link
Contributor Author

/cc @kishen-v

kishen-v
kishen-v reviewed Sep 23, 2024
View reviewed changes
.github/workflows/release.yml Outdated
livecheck: true
tag: ${{ steps.get_version.outputs.VERSION }}
revision: ${{github.sha}}
force: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
We may need to add a new line at the end of the file.
Ref: https://stackoverflow.com/questions/5813311/whats-the-significance-of-the-no-newline-at-end-of-file-log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

kishen-v
kishen-v reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@kishen-v kishen-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @carmal891, Thanks for the PR!
Just a minor comment to look into.

Thanks!

@kishen-v
Copy link
Contributor

/ok-to-test

@ppc64le-cloud-bot ppc64le-cloud-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2024
@mkumatag
Copy link
Member

depends on ppc64le-cloud/homebrew-pvsadm#6

mkumatag
mkumatag requested changes Sep 23, 2024
View reviewed changes
.gitignore Outdated
@@ -20,3 +20,6 @@ pvsadm

# audit logfile
pvsadm_audit.log

# operations logfile
pvsadm.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, lets add a newline here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

kishen-v
kishen-v reviewed Sep 24, 2024
View reviewed changes
.github/workflows/release.yml Outdated
tag: ${{ steps.get_version.outputs.VERSION }}
revision: ${{github.sha}}
force: false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@mkumatag
Copy link
Member

/hold

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2024
@carmal891 carmal891 closed this Oct 20, 2024
@carmal891 carmal891 mentioned this pull request Oct 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishen-v kishen-v kishen-v left review comments

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carmal891 @ppc64le-cloud-bot @kishen-v @mkumatag