Update to .NET 8 #160
Merged
Update to .NET 8 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package (or at least the Powershell part of it) is runtime dependent, and causes a build warning. I could either ignore the warning globally, or remove the package. I chose to remove the package because we don't deploy via Appveyor anymore.
smoogipoo
commented
Feb 2, 2024
| @@ -717,26 +715,6 @@ private static void pauseIfInteractive() | |||
| Console.WriteLine(); | |||
| } | |||
|
|
|||
| private static bool updateAppveyorVersion(string version) | |||
There was a problem hiding this comment.
See 0c96adb for explanation why.
bdach
approved these changes
Feb 5, 2024
|
$ rg net6.0
Program.cs
152: runCommand("dotnet", $"publish -f net6.0 -r win-x64 {ProjectName} -o \"{stagingPath}\" --configuration Release /p:Version={version}");
259: + " -f net6.0-android"
275: + " -f net6.0-ios"
304: runCommand("dotnet", $"publish -f net6.0 -r linux-x64 {ProjectName} -o {stagingTarget}/usr/bin/ --configuration Release /p:Version={version} --self-contained"); |
|
Is the |
|
I'd say it's good sanity against accidentally deploying on a higher runtime, but /shrug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereqs: