Refactor HitResult generation to make ruleset-specific behavior more explicit · ppy/osu-tools@66b20a6

Triggered via pull request November 15, 2024 17:11

Givikap120

opened #231

Status Success

Total duration 1m 41s

Artifacts –

ci.yml

on: pull_request

1 warning and 10 notices

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Code Quality: PerformanceCalculator/Performance/ReplayPerformanceCommand.cs#L76

Convert into primary constructor in PerformanceCalculator\Performance\ReplayPerformanceCommand.cs on line 76

Code Quality: PerformanceCalculator/ProcessorScoreDecoder.cs#L19

Convert into primary constructor in PerformanceCalculator\ProcessorScoreDecoder.cs on line 19

Code Quality: PerformanceCalculator/Simulate/OsuSimulateCommand.cs#L151

Dictionary lookup can be simplified with 'TryGetValue' in PerformanceCalculator\Simulate\OsuSimulateCommand.cs on line 151

Code Quality: PerformanceCalculator/Simulate/OsuSimulateCommand.cs#L160

Dictionary lookup can be simplified with 'TryGetValue' in PerformanceCalculator\Simulate\OsuSimulateCommand.cs on line 160

Code Quality: PerformanceCalculatorGUI/APIManager.cs#L28

Convert into primary constructor in PerformanceCalculatorGUI\APIManager.cs on line 28

Code Quality: PerformanceCalculatorGUI/Components/ExtendedOsuFileSelector.cs#L27

Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedOsuFileSelector.cs on line 27

Code Quality: PerformanceCalculatorGUI/Components/ExtendedOsuFileSelector.cs#L52

Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedOsuFileSelector.cs on line 52

Code Quality: PerformanceCalculatorGUI/Components/ExtendedProfileScore.cs#L43

Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedProfileScore.cs on line 43

Code Quality: PerformanceCalculatorGUI/Components/ExtendedUserModSelectOverlay.cs#L12

Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedUserModSelectOverlay.cs on line 12

Code Quality: PerformanceCalculatorGUI/Components/LeaderboardTable.cs#L34

Use collection expression in PerformanceCalculatorGUI\Components\LeaderboardTable.cs on line 34