Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export icon information in mods command #173

Closed
wants to merge 3 commits into from
Closed

Conversation

cl8n
Copy link
Member

@cl8n cl8n commented Jan 13, 2023

so that osu-web can render the icons without maintaining its own images etc.

not useful without ppy/osu#22175 and support on osu-web (haven't finished this yet, going to see how the osu PR goes first)

@peppy
Copy link
Member

peppy commented Jan 13, 2023

I'm not sure about consuming the FontAwesome icons instead of replacing them all into one consistent set (and only exposing an icon name, or even better, nothing at all)... but maybe this is okay?

@smoogipoo @arflyte thoughts? icons are all over the place right now.

@smoogipoo
Copy link
Contributor

I don't have any strong opinions either way as this can be changed later and any solution should be as minimal overhead as possible for us to continue progressing on the game rather than tooling.

@peppy peppy self-requested a review January 14, 2023 17:19
@cl8n
Copy link
Member Author

cl8n commented Aug 28, 2024

with the new suggested direction to not use icon fonts for mods, this would be unnecessary. for mods currently using fontawesome icons I plan to swap them to images all the same (maybe just web-side for that part... either way, point stands here).

@cl8n cl8n closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants