Update commands after game-side changes to accuracy/rank calculation #193
Conversation
| PopulateLegacyAccuracyAndRank(score.ScoreInfo); | ||
| score.ScoreInfo.LegacyTotalScore = score.ScoreInfo.TotalScore; | ||
| PopulateMaximumStatistics(score.ScoreInfo, beatmap); | ||
| StandardisedScoreMigrationTools.UpdateFromLegacy(score.ScoreInfo, beatmap); |
There was a problem hiding this comment.
This is fine for the time being if it's a best effort attempt, but I believe this is going to break for non-legacy scores?
Also, shouldn't IsLegacyScore be set?
There was a problem hiding this comment.
This is fine for the time being if it's a best effort attempt, but I believe this is going to break for non-legacy scores?
It probably will, I haven't considered that too much. We'll have to probably rewrite half of osu-tools to correctly handle non-legacy everywhere.
Also, shouldn't
IsLegacyScorebe set?
It probably should but I didn't notice since none of the commands that use it output total score. I'll fix though.
There was a problem hiding this comment.
Upon checking, the IsLegacyScore flag will already be correctly set in all relevant usages of this, because... it comes in from API correctly. So... no changes required? 🤔
LegacyScoreDecoder.PopulateMaximumStatistics()public osu#26785