Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicate difficulty & performance calculation when changing mods #222

Merged
merged 4 commits into from
Oct 23, 2024
Merged

fix duplicate difficulty & performance calculation when changing mods #222

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4821938
Fix duplicate diff & pp calculation when changing mods
minisbett Oct 13, 2024
1b84638
replace Count check with SequenceEqual
minisbett Oct 18, 2024
e508709
Merge branch 'master' into fix-duplicate-calculations
smoogipoo Oct 23, 2024
ca6ede4
Move nested function to end of parent
smoogipoo Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions PerformanceCalculatorGUI/Screens/SimulateScreen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,11 @@ protected override void Dispose(bool isDisposing)

private void modsChanged(ValueChangedEvent<IReadOnlyList<Mod>> mods)
{
// Hotfix for preventing a difficulty and performance calculation from being trigger twice,
// as the mod overlay for some reason triggers a ValueChanged twice per mod change.
if (mods.OldValue.Count == mods.NewValue.Count)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that disable recalculation when you're change mod settings?

Copy link
Contributor Author

@minisbett minisbett Oct 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mod settings are unaffected, they are being tracked by a separate piece of code.

osu-tools/PerformanceCalculatorGUI/Screens/SimulateScreen.cs

Lines 519 to 528 in e387265

modSettingChangeTracker = new ModSettingChangeTracker(mods.NewValue);
modSettingChangeTracker.SettingChanged += m =>
{
debouncedStatisticsUpdate?.Cancel();
debouncedStatisticsUpdate = Scheduler.AddDelayed(() =>
{
calculateDifficulty();
calculatePerformance();
}, 100);
};

minisbett marked this conversation as resolved.
Show resolved Hide resolved
return;

modSettingChangeTracker?.Dispose();

if (working is null)
Expand Down
Loading