Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix standard ruleset accuracy calculation on Lazer #229

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Fix standard ruleset accuracy calculation on Lazer #229

merged 2 commits into from
Nov 3, 2024

Conversation

minisbett
Copy link
Contributor

Resolves #226

Adds large tick hits and slider tail hits to the accuracy calculation. For that, the IBeatmap is now passed into the GetAccuracy method, although unused on any ruleset except standard.

smoogipoo
smoogipoo approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay

@smoogipoo smoogipoo merged commit 89b8f3b into ppy:master Nov 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect accuracy calculation for lazer
2 participants
@minisbett @smoogipoo