-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically create beatmap set description topic on edit if missing #11706
base: master
Are you sure you want to change the base?
Conversation
This is a solution to the problem of the new beatmap submission server not creating a description topic for the set like the old one did. Notably, this solution implies several shortcuts: - If the main metadata of the set (artist, title) don't change, the forum thread will not be renamed - The forum thread will be posted in a hardcoded forum and never moved, while old BSS would move the thread between forums 6 and 10 depending on whether the beatmap is pending or WIP. Not doing this saves a whole bunch of busy work. - There is no actual body in the forum thread OP, contrary to what old submission did. The aforementioned simplifications were made with the assumption that subforums 6 and 10 on production were going to be hidden away from users due to not containing any actual content that anyone would ever want to see. (Same thing applies to forum 19, which is graveyard.) The *one and only goal* here is that descriptions should be editable for maps submitted using new BSS. Thus I am taking pretty much the same shortcuts that places like the profile page already seem to be.
well this is originally my idea, so 🤷 and yay? 👍 and I think it doesn't have to reuse the existing forum...? |
Yeah I know you suggested it first. It's moreso that I want as many people as required to agree with this direction. @peppy most of all, probably.
It doesn't, sure. The default is set to something that would work on production immediately. Whether a new forum happens for this can be negotiated as one of the details to work out here. |
I have no issue with the direction, FWIW. |
Given there are no objections to general direction I'll undraft I suppose. That said the main question I'd have at this point is which forum ID to put the relevant forum topics in - is there going to be a new forum for them, or are we reusing existing? |
Following existing expectations should be fine (ie. using https://osu.ppy.sh/community/forums/6 / https://osu.ppy.sh/community/forums/10), unless I'm missing a reason for it to be separated? |
Um well as mentioned in the OP nowhere in this diff am I moving the relevant thread from the pending forum to the WIP forum or the other way around as the user changes the beatmap's status from pending to WIP or the other way around. web-10 does this on submission. Doing this would require special handling, likely triggered by |
Right. To clarify on that, moving between the forums is largely a historic thing, and I don't think it needs to happen (the important movements to ranked or to graveyard are handled elsewhere anyways). We could just choose one (likely the pending forum |
Switched to this one in 6f8dade. If we're using that one then I guess the other question would be whether I should bother to give the post any actual content. As in, old BSS topics had actual content before the description (example: https://osu.ppy.sh/community/forums/topics/2021687?n=1), while the ones created here don't really bother with that and just do the description part. |
Note
Please consider this PR as a request for comments / starting point of discussion. It is by no means intended to be 100% complete, and as such I'm opening it as draft until that initial discussion has ran its course and any potential objections have been addressed.
This is a solution to the problem of the new beatmap submission server not creating a description topic for the set like the old one did. Notably, this solution implies several shortcuts:
The aforementioned simplifications were made with the assumption that subforums 6 and 10 on production were going to be hidden away from users due to not containing any actual content that anyone would ever want to see. (Same thing applies to forum 19, which is graveyard - although old threads pre-modding V2 actually do have useful content there. Not sure what to do about that.)
The one and only goal here is that descriptions should be editable for maps submitted using new BSS. Thus I am taking pretty much the same shortcuts that places like the profile page already seem to be.