Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] improved french translation #12420

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[FR] improved french translation #12420

wants to merge 7 commits into from

Conversation

sbnh1
Copy link

@sbnh1 sbnh1 commented Nov 10, 2024

change in the following files :

  • wiki/Gameplay/Combo_(score_multiplier)/fr.md
  • wiki/Gameplay/Combo_fire/fr.md
  • wiki/Gameplay/Combo_milestone/fr.md
  • wiki/Gameplay/Combo_multiplier_effect/fr.md
  • wiki/Gameplay/Comboburst/fr.md
  • wiki/Gameplay/Full_combo/fr.md
  • wiki/Gameplay/Health/fr.md
  • wiki/Gameplay/Mind_block/fr.md
  • wiki/Gameplay/Replay/fr.md
  • wiki/Gameplay/Spectating/fr.md
  • wiki/Gameplay/Spinner_trap/fr.md
  • wiki/Gameplay/Tablet_cover/fr.md
  • wiki/Gameplay/Unstable_rate/fr.md
  • wiki/Gameplay/fr.md

I see that the categories "full combo", "health" and "hit object" were missing in the index (I’m not sure if this was intentional). I’ve added them to the last file mentioned.

I adjusted the phrasing and clarified the terminology in various sections to improve clarity.

Self-check

Copy link

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

@sbnh1 sbnh1 changed the title [FR] improved french translation [EN][FR] improved french translation and rewite of article "Hit circle" (en) Nov 15, 2024
@sbnh1 sbnh1 changed the title [EN][FR] improved french translation and rewite of article "Hit circle" (en) [FR] improved french translation Nov 15, 2024
Copy link
Contributor

@LeZozoien LeZozoien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a native french speaker, this seems all good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants