Add ability to close playlists within grace period after creation #30793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we might want to, in addition to the context menu, show a button next to "Start" on the playlist screen for discoverability. What do you think? |
|
Yeah I considered doing that. Not opposed to it in principle, will give it a go. |
Was making the close button not display when creating a room anew.
|
Something like this I guess...? |
|
Yeah, seems good. Although that footer looks horribly bad with this plus the back button, but 🙈 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30401.
2024-11-20.12-36-55.mp4
Grace period in question is configurable osu-web side via
MULTIPLAYER_ROOM_CLOSE_GRACE_PERIOD_MINUTESenvvar; default is 5 minutes (see ppy/osu-web#11667). Same value is hardcoded in client.Not sure the lounge context menu is the best place for this necessarily but that was kinda simplest...?
No tests because it felt like adding them would be too expensive for the benefit, but will add on request.