Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a JudgementProcessor to provide a rate-scaled time offset of a JudgementResult #30842

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow a JudgementProcessor to provide a rate-scaled time offset of a JudgementResult #30842

wants to merge 3 commits into from

Commits on Nov 22, 2024

  1. Allow a JudgementProcessor to provide a rate-scaled time offset of … 

    …a `JudgementResult`

Closes ppy#30828.

I'm not convinced this is the absolute cleanest solution, but I've made it in such a way that it doesn't require too much messing around with hit/judgement processing.
    @tsunyoku
    tsunyoku committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    079868c View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2024

  1. Use a "time scale" instead of "scaled time offset" in HitEvent

    @tsunyoku
    tsunyoku committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    98d9568 View commit details
    Browse the repository at this point in the history

  2. Make TimeScale nullable similarly to old GameplayRate logic

    @tsunyoku
    tsunyoku committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    a26c94f View commit details
    Browse the repository at this point in the history