-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taiko length bonus fix by calculating consistency for each skill #31494
base: pp-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, can we have some documentation surrounding how this works? Whilst I am familiar with the general concept by reading the code, maybe some notable values changes etc? Also, you'll need to fix commit history.
osu.Game.Rulesets.Taiko/Difficulty/TaikoPerformanceCalculator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoPerformanceCalculator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyCalculator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyCalculator.cs
Outdated
Show resolved
Hide resolved
6f21c43
to
b4d054f
Compare
9e98316
to
f6a22c6
Compare
07faf63
to
5bc5cc3
Compare
Please read above. |
fb0915c
to
6fde2da
Compare
Sorry I didn't see it before. I've also prepared documentation for my concept. |
6fde2da
to
b63e958
Compare
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyCalculator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoPerformanceCalculator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoPerformanceCalculator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyCalculator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyCalculator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyCalculator.cs
Outdated
Show resolved
Hide resolved
a7ab355
to
da3f877
Compare
/// The factor corresponding to the consistency of each skill. | ||
/// </summary> | ||
[JsonProperty("total_consistency_factor")] | ||
public double TotalConsistencyFactor { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this a global difficulty attribute ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to add this to each game mode, so I need it to be global.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't need to be global, as this is directly targeting the taiko ruleset.
6dd56ce
to
e7dbde5
Compare
The change modifies:
For all gamemode:
For taiko only:
Documentation: https://docs.google.com/document/d/e/2PACX-1vTbg_vnQndZd3EzFb4ke7KPN65BPSya7urQFxya7ykUXQYM6mq8sUiAcxL6TNBAu6Bg_7RfVE71VPDR/pub