Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taiko length bonus fix by calculating consistency for each skill #31494

Open
wants to merge 6 commits into
base: pp-dev
Choose a base branch
from

Conversation

TheDark98
Copy link

@TheDark98 TheDark98 commented Jan 13, 2025

The change modifies:

For all gamemode:

  • New value, ConsistencyFactor, new variable to calculate the consistency of the map, represented by a value from 0 to 1, where 1 represents the highest consistency possible in a map and 0 the lowest consistency possible in a map..

For taiko only:

  • ConsistencyFactor for each skill.
  • New length bonus formula calculated with ConsistencyFactor for each skill + total.
  • Length bonus affect star rating.

Documentation: https://docs.google.com/document/d/e/2PACX-1vTbg_vnQndZd3EzFb4ke7KPN65BPSya7urQFxya7ykUXQYM6mq8sUiAcxL6TNBAu6Bg_7RfVE71VPDR/pub

Copy link
Member

@Lawtrohux Lawtrohux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, can we have some documentation surrounding how this works? Whilst I am familiar with the general concept by reading the code, maybe some notable values changes etc? Also, you'll need to fix commit history.

@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix-Taiko branch 5 times, most recently from 07faf63 to 5bc5cc3 Compare January 14, 2025 14:43
@Lawtrohux
Copy link
Member

Overall, can we have some documentation surrounding how this works? Whilst I am familiar with the general concept by reading the code, maybe some notable values changes etc?

Please read above.

@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix-Taiko branch 6 times, most recently from fb0915c to 6fde2da Compare January 15, 2025 21:15
@TheDark98
Copy link
Author

Overall, can we have some documentation surrounding how this works? Whilst I am familiar with the general concept by reading the code, maybe some notable values changes etc?

Please read above.

Sorry I didn't see it before. I've also prepared documentation for my concept.

@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix-Taiko branch from 6fde2da to b63e958 Compare January 15, 2025 23:16
@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix-Taiko branch from a7ab355 to da3f877 Compare January 16, 2025 07:18
/// The factor corresponding to the consistency of each skill.
/// </summary>
[JsonProperty("total_consistency_factor")]
public double TotalConsistencyFactor { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a global difficulty attribute ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add this to each game mode, so I need it to be global.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't need to be global, as this is directly targeting the taiko ruleset.

@TheDark98 TheDark98 force-pushed the Length-Bonus-Fix-Taiko branch from 6dd56ce to e7dbde5 Compare January 17, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants