Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify events news #97

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Simplify events news #97

merged 2 commits into from
Feb 9, 2025

Conversation

mingness
Copy link
Member

@mingness mingness commented Feb 6, 2025

rename news collection to announcements, since items in news collection showed up in filter over all documents for tags with news value, even when the item in the news collection didn't have the tag news.
decouple media for events and announcements - events and announcements have their own media folders, remove spurious fields
news items on home page now is a filter over all items with tag news, no limit.
consolidate events and announcement layout to entry
consolidate start_date and publish_date fields to date

Copy link

github-actions bot commented Feb 6, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-09 16:45 UTC

@mingness mingness requested a review from hamoid February 6, 2025 23:50
@mingness
Copy link
Member Author

mingness commented Feb 6, 2025

There are a lot of changes in this PR after all. This could be split into smaller PRs.

Copy link
Member

@hamoid hamoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Announcements and events are not yet in the admin, right? I don't seem them listed there.

@mingness
Copy link
Member Author

mingness commented Feb 8, 2025

That's right, it's not in decap yet. The decap PR will need to be changed to adjust to this PR

@mingness mingness merged commit 23833fd into main Feb 9, 2025
1 check passed
@mingness mingness deleted the simplify-events-news branch February 9, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants