Code

Repo consistency#639

Code

Open

fritzbrand wants to merge 43 commits intodeveloppraekeltfoundation/ndoh-hub:developfrom repo-consistencypraekeltfoundation/ndoh-hub:repo-consistencyCopy head branch name to clipboard

+1,921-298

Commits

Commits on Oct 17, 2024

• Need to merge develop back in

  fritzbrand

  committed
  9126a9f

  Copy full SHA for 9126a9f

• Merge branch 'develop' into repo-consistency

  fritzbrand

  committed
  d47888e

  Copy full SHA for d47888e

• Added direct git install for iso639

  fritzbrand

  committed
  6f9842a

  Copy full SHA for 6f9842a

• Perparing to remove pip

  fritzbrand

  committed
  9996a04

  Copy full SHA for 9996a04

• Unpinned versions

  fritzbrand

  committed
  a45b777

  Copy full SHA for a45b777

• Pinned specific 'rapidpro-python' version

  fritzbrand

  committed
  904614d

  Copy full SHA for 904614d

• Added blanket ignores until ruff throws no errors

  fritzbrand

  committed
  5a88fc4

  Copy full SHA for 5a88fc4

Commits on Oct 21, 2024

• Redefinition of unused and ruff format

  fritzbrand

  committed
  a9f57f1

  Copy full SHA for a9f57f1

• Use 'enumerate()' for index variable 'total' in 'for' loop

  fritzbrand

  committed
  346e40f

  Copy full SHA for 346e40f

• Use ternary operator instead of 'if'-'else'-block

  fritzbrand

  committed
  a7c53c2

  Copy full SHA for a7c53c2

• Return the condition 'label in labels' directly

  fritzbrand

  committed
  3d470a6

  Copy full SHA for 3d470a6

• 'typing.Text' is deprecated, use 'str'

  fritzbrand

  committed
  95a413f

  Copy full SHA for 95a413f

• Unnecessary 'map' usage (rewrite using a generator expression)

  fritzbrand

  committed
  e4fd7bd

  Copy full SHA for e4fd7bd

• Do not use mutable data structures for argument defaults

  fritzbrand

  committed
  a4e5d64

  Copy full SHA for a4e5d64

• Found useless expression. Either assign it to a variable or remove it.

  fritzbrand

  committed
  570704f

  Copy full SHA for 570704f

• Possible hardcoded password assigned

  fritzbrand

  committed
  d982515

  Copy full SHA for d982515

• Unnecessary imports for target Python version

  fritzbrand

  committed
  721c825

  Copy full SHA for 721c825

• Within an 'except' clause, raise exceptions with 'raise ... from err' or 'raise ... from None'

  fritzbrand

  committed
  462ce1b

  Copy full SHA for 462ce1b

• Standard pseudo-random generators are not suitable for cryptographic purposes

  fritzbrand

  committed
  3fb00c5

  Copy full SHA for 3fb00c5

• Use 'super()' instead of 'super(__class__, self)'

  fritzbrand

  committed
  fed49a6

  Copy full SHA for fed49a6

• Use format specifiers instead of percent format

  fritzbrand

  committed
  ac1974f

  Copy full SHA for ac1974f

• 'try'-'except'-'continue' detected, consider logging the exception

  fritzbrand

  committed
  61b890a

  Copy full SHA for 61b890a

• Use 'contextlib.suppress(Exception)' instead of 'try'-'except'-'pass'

  fritzbrand

  committed
  13ec3dd

  Copy full SHA for 13ec3dd

• Use a single 'if' statement instead of nested 'if' statements

  fritzbrand

  committed
  340904e

  Copy full SHA for 340904e

• Use 'is' and 'is not' for type comparisons, or 'isinstance()' for isinstance checks

  fritzbrand

  committed
  3072035

  Copy full SHA for 3072035

• Use 'return any(post in group[name].lower() for group in contact[groups])' instead of 'for' loop

  fritzbrand

  committed
  7bd8a0f

  Copy full SHA for 7bd8a0f

• 'try'-'except'-'pass' detected, consider logging the exception

  fritzbrand

  committed
  1f1eb00

  Copy full SHA for 1f1eb00

• Possible hardcoded password assigned to argument

  fritzbrand

  committed
  143e247

  Copy full SHA for 143e247

• Loop control variable 'status_code' not used within loop body

  fritzbrand

  committed
  e4e40d3

  Copy full SHA for e4e40d3

• Class 'Template' inherits from 'object'

  fritzbrand

  committed
  4f8c9a9

  Copy full SHA for 4f8c9a9

• Unnecessary 'list' comprehension (rewrite using 'list()')

  fritzbrand

  committed
  2febd39

  Copy full SHA for 2febd39

• Use implicit references for positional format fields

  fritzbrand

  committed
  94575cd

  Copy full SHA for 94575cd

• 'open()' should be replaced by 'Path.open()' maybe use pathlib

  fritzbrand

  committed
  0c5fa39

  Copy full SHA for 0c5fa39

• Use f-string instead of 'format' call

  fritzbrand

  committed
  9a93005

  Copy full SHA for 9a93005

Commits on Oct 22, 2024

• GitHub Actions update

  fritzbrand

  committed
  fd2c60f

  Copy full SHA for fd2c60f

• Update Dockerfile

  fritzbrand

  committed
  3b2c0bc

  Copy full SHA for 3b2c0bc

Commits on Oct 23, 2024

• Update merge conflicts

  fritzbrand

  committed
  9b2034b

  Copy full SHA for 9b2034b

• Removed setup.py and updated test.yaml

  fritzbrand

  committed
  958975e

  Copy full SHA for 958975e

• Removed global S106 ignore, and added inline ignores

  fritzbrand

  committed
  5b2d52d

  Copy full SHA for 5b2d52d

• RUF - enabled ruff-specific rules

  fritzbrand

  committed
  7d8bc10

  Copy full SHA for 7d8bc10

• Formatting

  fritzbrand

  committed
  e54ac24

  Copy full SHA for e54ac24

• Updated wording for S106 inlines

  fritzbrand

  committed
  165fac8

  Copy full SHA for 165fac8

Commits on Oct 24, 2024

• Updates after feedback

  fritzbrand

  committed
  f54b07e

  Copy full SHA for f54b07e