Keep track of words tweeted and choose random word at the end of the day #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elif word_count == no_of_words_per_day: | ||
| print('\ntodays_words:',todays_words) | ||
| question = list(random.choice(todays_words)) |
There was a problem hiding this comment.
You could by default make word a list type, instead of a tuple
There was a problem hiding this comment.
The two elements of the tuple (tweet_id and answer) are always needed together so it makes sense to combine them in a tuple. Also, a list would be useful in cases where there is a possibility of adding more elements. That isn't the case here.
There was a problem hiding this comment.
Yes but since you're converting it back to a list type later on, might as well have it as a list in the first place. just for cleaner code that's all
There was a problem hiding this comment.
Remove redundant lines and comments, and test the code. I'll merge the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state of code is for testing purposes. Commented lines need to be un-commented and a few other lines need to be removed for proper functionality