Improved behat

prasanna-lmsace · Nov 26, 2023 · ef94116 · ef94116
1 parent a1e1eee
commit ef94116
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/automation/automationlib.php b/automation/automationlib.php
@@ -50,7 +50,6 @@ public function definition() {
         $templates = [0 => ''] + mod_pulse\automation\helper::get_templates_forinstance($courseid);
         if (!empty($templates)) {
             $mform->addElement('autocomplete', 'templateid', '', $templates);
-            // $mform->addRule('templateid', get_string('required'), 'required', '', 'client');
         }
 
         $this->add_action_buttons(true, get_string('addtemplatebtn', 'pulse'));

diff --git a/classes/task/notify_users.php b/classes/task/notify_users.php
@@ -164,7 +164,10 @@ public static function pulse_cron_task($extend=true) {
             $instance->context = (object) $context;
             $instance->cm = (object) $cm;
             $instance->students = $students;
-            self::pulse_set_notification_adhoc($instance);
+            // Students are available.
+            if (!empty($students)) {
+                self::pulse_set_notification_adhoc($instance);
+            }
         }
         pulse_mtrace('Pulse message sending completed....');
         return true;