Fixed CI grunt and report builder issues

prasanna-lmsace · Nov 25, 2023 · f96a2e4 · f96a2e4
1 parent 7f96f45
commit f96a2e4
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 10 deletions.
diff --git a/actions/notification/amd/build/chaptersource.min.js b/actions/notification/amd/build/chaptersource.min.js
diff --git a/actions/notification/amd/build/chaptersource.min.js.map b/actions/notification/amd/build/chaptersource.min.js.map
diff --git a/actions/notification/classes/notification.php b/actions/notification/classes/notification.php
@@ -716,6 +716,7 @@ protected function generate_the_scheduletime($userid, $lastrun=null, $expectedru
      *
      * @param array $roles Role ids to fetch
      * @param \context $context
+     * @param int $childuserid
      * @return array List of the users.
      */
     protected function get_users_withroles(array $roles, $context, $childuserid=null) {

diff --git a/actions/notification/classes/reportbuilder/datasource/notification.php b/actions/notification/classes/reportbuilder/datasource/notification.php
@@ -121,9 +121,7 @@ public function get_default_columns(): array {
      * @return array
      */
     public function get_default_filters(): array {
-        return [
-            'notification:instanceid'
-        ];
+        return [];
     }
 
     /**
@@ -133,9 +131,7 @@ public function get_default_filters(): array {
      */
     public function get_default_conditions(): array {
 
-        return [
-            'notification:instanceid'
-        ];
+        return [];
     }
 
 }
diff --git a/amd/build/automation.min.js b/amd/build/automation.min.js
diff --git a/amd/build/module.min.js b/amd/build/module.min.js
diff --git a/classes/automation/instances.php b/classes/automation/instances.php
@@ -313,6 +313,11 @@ public function get_report_url() {
         return $url;
     }
 
+    /**
+     * Get the id of the instance report builder.
+     *
+     * @return int
+     */
     public static function get_reportid() {
         global $DB;