Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keybinding for move to special workspace #1886

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rubiin
Copy link
Contributor

@rubiin rubiin commented Sep 25, 2024

Pull Request

add keybinding for move to special workspace
keeping the pattern similar to how active window is moved with other numbered workspace

Description

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 27, 2024

Dunno but this one is my key bind for screenshots lol. I don't know why it's familiar to me.

@zeerayne
Copy link
Contributor

Likely because this is default keybinding for Windows snipping tool

@rubiin
Copy link
Contributor Author

rubiin commented Sep 27, 2024

you can override anyway :D just keeping the semantics

@XBEAST1
Copy link
Contributor

XBEAST1 commented Sep 30, 2024

you can override anyway :D just keeping the semantics

same here i'm also using Win+shift+S to move window to special workspace since last 2 months

@rubiin
Copy link
Contributor Author

rubiin commented Oct 1, 2024

you can override anyway :D just keeping the semantics

same here i'm also using Win+shift+S to move window to special workspace since last 2 months

Yeah I have just added special workspace to my daily workflow. I was using a numbered workspace as a scratch pad but since special workspace was kind of built for this specific purpose , switched to using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants