Fix --const-label option (prometheus-community#113)

Signed-off-by: tamareyal <[email protected]> Co-authored-by: tamareyal <[email protected]> Signed-off-by: Prateek <[email protected]>
prateeknayak · Jan 15, 2025 · 1f4e13d · 1f4e13d
1 parent 779e85e
commit 1f4e13d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/metrics/serve.go b/metrics/serve.go
@@ -514,12 +514,12 @@ func (c *Collector) Run() error {
 		labelValues = append(labelValues, split[1])
 	}
 
-	c.labelKeys = labelKeys
 	mutableState := &metricState{seriesCount: c.cfg.SeriesCount, labelValues: labelValues}
 	// unsafe means you need to lock c.mu to use it.
 	unsafeReadOnlyGetState := func() metricState { return *mutableState }
 
 	c.mu.Lock() // Just to make race detector happy, not really needed in practice.
+	c.labelKeys = labelKeys
 	c.gauges = make([]*prometheus.GaugeVec, c.cfg.GaugeMetricCount)
 	c.counters = make([]*prometheus.CounterVec, c.cfg.CounterMetricCount)
 	c.histograms = make([]*prometheus.HistogramVec, c.cfg.HistogramMetricCount)