Fix table headers #1003
Open
Fix table headers #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stormsilver Thank you for your contribution. Could you please provide specs for the fixes so that these bugs would never come back? |
pointlessone
force-pushed
the
master
branch
2 times, most recently
from
3c5df3e
to
8309626
Compare
stormsilver
force-pushed
the
fix_table_headers
branch
5 times, most recently
from
d54f1ce
to
23ae60c
Compare
|
@pointlessone I added a spec for the margins fix, but I was really really really unsure how to test the vertical alignment. I poked around the tests from the original PR but they passed with or without my code change, which seemed... wrong. |
This fixes a problem where table headers with valign: bottom were too close to the bottom border.
stormsilver
force-pushed
the
fix_table_headers
branch
from
23ae60c
to
3925f60
Compare
Closed
|
As pointed in #1137 (comment), I believe this PR is likely stale and has already been integrated (2.2.0...2.2.1) via a separate commit if I'm not mistaken! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things in this PR (I know, I know - I am bad and I feel bad)
valign: :bottomare too close to the bottom border (the bottoms of my g's and p's and y's and q's are touching that border. Mama always said to mind your p's and q's - I guess this is what she was talking about. She's a lot smarter than I ever gave her credit for when I was 16). It looks like originallyfinal_gapwas included in the fix but then removed because... something? Adding it back makes things look good again, but I don't know what other problems this could cause.