prax: add non-native-fee-warning #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
requested changes
Nov 25, 2024
TalDerei
commented
Nov 25, 2024
Comment on lines
54
to
64
| {selectedTransactionViewName === TransactionViewTab.SENDER && symbol !== 'UM' && ( | ||
| <div | ||
| style={{ marginBottom: '16px' }} | ||
| className='rounded border border-yellow-500 p-2 text-yellow-500 text-sm' | ||
| > | ||
| <span className='block text-center font-bold'>⚠ Privacy Warning:</span> | ||
| Transaction uses a non-native fee token. To reduce gas costs and protect your privacy, | ||
| maintain an UM balance for fees. | ||
| </div> | ||
| )} | ||
|
|
There was a problem hiding this comment.
alternatively, we can implement a tooltip (using the react-tooltip library) with a hover animation
There was a problem hiding this comment.
I think it's fine, hopefully the user only sees this once or twice
hdevalence
approved these changes
Nov 25, 2024
grod220
reviewed
Nov 25, 2024
| @@ -47,7 +50,18 @@ export const TransactionApproval = () => { | |||
|
|
|||
| return ( | |||
| <div className='flex h-screen flex-col'> | |||
| <div className='grow overflow-auto p-[30px] pt-10'> | |||
| <div className='flex grow flex-col overflow-auto p-[30px] pt-10'> | |||
| {selectedTransactionViewName === TransactionViewTab.SENDER && symbol !== 'UM' && ( | |||
There was a problem hiding this comment.
suggestion: think this would be simpler if we ditched the whole useEffect pattern and just did something like:
const hasAltGasFee = (txv?: TransactionView): boolean => {
const { stakingAssetId } = new ChainRegistryClient().bundled.globals();
return txv?.bodyView?.transactionParameters?.fee?.assetId?.equals(stakingAssetId) ?? false;
};
...
return (
<div className='flex h-screen flex-col'>
<div className='flex grow flex-col overflow-auto p-[30px] pt-10'>
{selectedTransactionViewName === TransactionViewTab.SENDER &&
hasAltGasFee(selectedTransactionView) && (
<div
...There was a problem hiding this comment.
helper function is a better approach here 👍
There was a problem hiding this comment.
txv?.bodyView?.transactionParameters?.fee?.assetId? is undefined, so modified the logic slightly
const hasAltGasFee = (txv?: TransactionView): boolean => {
const { stakingAssetId } = new ChainRegistryClient().bundled.globals();
let feeAssetId = txv?.bodyView?.transactionParameters?.fee?.assetId;
if (feeAssetId === undefined) {
feeAssetId = stakingAssetId;
}
return feeAssetId.equals(stakingAssetId);
};...
{selectedTransactionViewName === TransactionViewTab.SENDER && !hasAltGasFee(selectedTransactionView) && (
|
I’ll wait to merge until #241 is complete, so I can compare how the privacy warning appears in the updated approval dialog design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second part of penumbra-zone/web#1882
focused more on functionality rather than design, which definitely has room for improvement.