Support de-camelCasing JSX html attributes #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taken the list of Preact supported attributes[1] and transform these attributes when building the rendered string. [1] https://github.com/developit/preact/blob/f717ee8e53248d75ff8c1a46966adeec295d339b/src/preact.d.ts#L547
|
We just ran into this bug today regarding srcSet attribute, would love to see this guy merged in :) |
gpoitch
suggested changes
Feb 22, 2018
| spellCheck: 'spell-check', | ||
| srcDoc: 'src-doc', | ||
| srcLang: 'src-lang', | ||
| srcSet: 'src-set', |
| srcDoc: 'src-doc', | ||
| srcLang: 'src-lang', | ||
| srcSet: 'src-set', | ||
| tabIndex: 'tab-index', |
|
Hiya! Sorry for the delay in responding to PRs. I'm wondering about the size impact of this, versus using a regular expression transform like |
|
@developit the RegEx approach would suffer from the issue of transforming Combining both with a list of html attributes that need the hyphen to be removed might be a way to go. Any other ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken the list of Preact supported attributes and transform these attributes when building the rendered string.