rubiconBidAdapter.js: ensure unique imp IDs for twin adunits #12303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertrmartinez
requested changes
Oct 8, 2024
| adUnitCodeCount[adUnitCode] = 1; | ||
| } | ||
| // update adunit map so we can translate back to original adunit code | ||
| impIdMap[imp.id] = adUnitCode; |
There was a problem hiding this comment.
not sure we need both adUnitCodeCount and impIdMap
would this just work something like
const adUnitCode = imp.id;
if (impIdMap[adUnitCode]) {
imp.id = `${adUnitCode}-${impIdMap[adUnitCode]}`; // I like adding a - to keep them separate
impIdMap[adUnitCode] += 1;
} else {
impIdMap[adUnitCode] = 1;
}Then just reset like you do after toORTB
impIdMap = {};
Might be missing something.
I think the imp function is called one after other so we do not need to handle other auctions or something.
patmmccann
changed the title
|
you guys are on my #12171 tasklist, can you fix as part of this or your next pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information