Deprecate methods and properties for 3.0 #1109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlenaPostindustria
requested changes
Feb 27, 2025
PrebidMobile/AdUnits/AdUnit.swift
Outdated
| @@ -305,22 +305,26 @@ public class AdUnit: NSObject, DispatcherDelegate { | |||
|
|
|||
| /// This method obtains the ext data keyword & value for adunit targeting. | |||
| /// If the key already exists the value will be appended to the list. No duplicates will be added | |||
| @available(*, deprecated, message: "This method is deprecated. In the upcoming major release, the method will be removed.") | |||
There was a problem hiding this comment.
We need to clearly indicate in the message which alternative method should be used in place of the deprecated one. This could be achieved either through a global-level method from the Targeting class or by using the setImpORTBConfig/setGlobalORTBConfig methods.
PrebidMobile/Host.swift
Outdated
| @@ -19,9 +19,11 @@ import UIKit | |||
| @objc public enum PrebidHost: Int { | |||
|
|
|||
| /// URL [https://ib.adnxs.com/openrtb2/prebid](URL) | |||
| @available(*, deprecated, message: "This property is deprecated. In the upcoming major release, the property will be removed.") | |||
There was a problem hiding this comment.
Maybe we should also deprecate Prebid.prebidServerHost ? I don't think we'll need it anymore.
| @@ -355,17 +364,20 @@ public class InterstitialRenderingAdUnit: NSObject, BaseInterstitialAdUnitProtoc | |||
|
|
|||
| /// Adds user data objects. | |||
| /// - Parameter userDataObjects: The user data objects to be added. | |||
| @available(*, deprecated, message: "This method is deprecated. In the upcoming major release, the method will be removed.") | |||
There was a problem hiding this comment.
What should be used instead of addUserData ?
PrebidMobile/AdUnits/AdUnit.swift
Outdated
| @@ -305,22 +305,26 @@ public class AdUnit: NSObject, DispatcherDelegate { | |||
|
|
|||
| /// This method obtains the ext data keyword & value for adunit targeting. | |||
| /// If the key already exists the value will be appended to the list. No duplicates will be added | |||
| @available(*, deprecated, message: "This method is deprecated. In the upcoming major release, the method will be removed. Please, use Targeting.addAppExtData method instead.") | |||
There was a problem hiding this comment.
Are we replacing what goes into imp[].ext.data(addExtData) with what goes into app.ext.data(Targeting.addAppExtData)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1009
#1007
#1006