Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alkimi: Added support for Imp extention object #3743

Open
wants to merge 97 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 96 commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
3a264d7
added adapter
mihanikw2g Dec 1, 2021
f472763
AlkimiBidder adapter
pro-nsk Dec 6, 2021
b6cf616
AlkimiBidder adapter
pro-nsk Dec 6, 2021
769221d
AlkimiBidder adapter config
pro-nsk Dec 6, 2021
76e4609
AlkimiBidder adapter config
pro-nsk Feb 10, 2022
8036358
added Jenkinsfile
abalalaev Mar 10, 2022
3aebb2e
changed jenkinsfile
abalalaev Mar 10, 2022
4e5939f
changed jenkinsfile
abalalaev Mar 10, 2022
6de85e1
changed jenkinsfile
abalalaev Mar 10, 2022
210281d
changed dockerfile
abalalaev Mar 10, 2022
8febe50
changed dockerfile
abalalaev Mar 10, 2022
1217175
changed dockerfile
abalalaev Mar 10, 2022
941771d
adde alkimi.yaml.demo
abalalaev Mar 10, 2022
bfbe15e
adde alkimi.yaml.demo
abalalaev Mar 10, 2022
120d5ce
adde alkimi.yaml.demo
abalalaev Mar 10, 2022
ad78425
AlkimiBidder test
pro-nsk Apr 20, 2022
a7704f1
Merge remote-tracking branch 'origin/master'
pro-nsk Apr 20, 2022
6fd8b8c
Merge pull request #1 from prebid/master
pro-nsk Apr 22, 2022
7c08517
Alkimi exchange endpoint
pro-nsk Apr 22, 2022
26fbdc9
Alkimi Prebid Server Adapter fixes
pro-nsk Apr 22, 2022
34fd310
Alkimi Prebid Server Adapter integration test
pro-nsk Apr 26, 2022
ee2edde
Alkimi Prebid Server Adapter test. LineLength fix
pro-nsk Apr 26, 2022
054a783
Alkimi Prebid Server Adapter test. config fix
pro-nsk Apr 27, 2022
8a884e3
Alkimi Prebid Server Adapter test. Fixes after review
pro-nsk Apr 29, 2022
805b872
Alkimi Prebid Server Adapter test. Fixed unused imports
pro-nsk May 4, 2022
6b21991
Alkimi Bidder, format fixes
pro-nsk May 5, 2022
d05a9d7
Merge remote-tracking branch 'origin/master'
pro-nsk May 5, 2022
de9d977
Alkimi Bidder, change maintainer info
pro-nsk May 11, 2022
1387d7a
Merge pull request #2 from prebid/master
pro-nsk May 16, 2022
72e3fb8
Alkimi Prebid Server Adapter. Test file update
pro-nsk May 16, 2022
81867bd
Merge branch 'master' of github.com:prebid/prebid-server-java into ma…
pro-nsk Nov 8, 2022
0160069
Add adUnitCode to Alkimi Ext
pro-nsk Nov 8, 2022
9bab92e
Alkimi Bidder, fix config
pro-nsk Nov 8, 2022
b57d5a1
Merge pull request #4 from prebid/master
pro-nsk Mar 15, 2023
1655139
update alkimi support email
pro-nsk Mar 15, 2023
83783ab
Merge pull request #5 from prebid/master
pro-nsk Jun 20, 2023
8729492
Merge pull request #6 from prebid/master
pro-nsk Jul 21, 2023
de3736b
added jenkinsfile
abalalaev Jul 24, 2023
ba1fc61
changed root pom
abalalaev Jul 24, 2023
76612d6
changed java version to 17
abalalaev Jul 24, 2023
2964339
fixed java home
abalalaev Jul 24, 2023
0874531
disabled tests
abalalaev Jul 24, 2023
829af3b
changed jenkinsfile
abalalaev Jul 24, 2023
77f2823
changed jenkinsfile
abalalaev Jul 24, 2023
d0c7364
changed jenkinsfile
abalalaev Jul 24, 2023
2dc714d
spring-boot-maven-plugin change
pro-nsk Jul 24, 2023
929cb81
spring-boot-maven-plugin change
pro-nsk Jul 24, 2023
2836986
changed jenkinsfile
abalalaev Jul 24, 2023
24e65d6
spring-boot-maven-plugin change
pro-nsk Jul 24, 2023
6b34162
spring-boot-maven-plugin change
pro-nsk Jul 24, 2023
7241e43
spring-boot-maven-plugin change
pro-nsk Jul 24, 2023
6cfd230
spring-boot-maven-plugin change
pro-nsk Jul 24, 2023
a00b284
spring-boot-maven-plugin change
pro-nsk Jul 24, 2023
b47b8a0
changed java home
abalalaev Jul 25, 2023
804cb4a
changed jenkinsfile
abalalaev Jul 25, 2023
cd1f596
changed root pom
abalalaev Jul 25, 2023
9f72a1c
changed root pom
abalalaev Jul 25, 2023
4992dd6
changed root pom
abalalaev Jul 25, 2023
f07faf5
changed jenkinsfile
abalalaev Jul 25, 2023
3f9e793
changed jenkinsfile
abalalaev Jul 25, 2023
42adf90
changed jenkinsfile
abalalaev Jul 25, 2023
0b984dc
changed jenkinsfile
abalalaev Jul 25, 2023
34391e7
added config dir
abalalaev Jul 25, 2023
c63eea1
changed jenkinsfile
abalalaev Jul 25, 2023
76c9786
fixed adapter name
abalalaev Jul 25, 2023
61af21b
test jenkinsfile change
pro-nsk Jul 25, 2023
84a5005
fix configs
pro-nsk Jul 25, 2023
ee0833e
update bidFloor
pro-nsk Jul 27, 2023
0103985
remove static import
pro-nsk Jul 27, 2023
f25f50c
fix line length
pro-nsk Jul 27, 2023
4f7e4c4
enable tests
pro-nsk Jul 27, 2023
d0ee3f1
remove required bidFloor
pro-nsk Jul 31, 2023
02b2655
Update ExtImpAlkimi
pro-nsk Jul 31, 2023
7a4529a
unused imports
pro-nsk Jul 31, 2023
608c089
fix tests
pro-nsk Jul 31, 2023
4293395
clear pom
pro-nsk Jul 31, 2023
3af0e19
add description for optional params
pro-nsk Jul 31, 2023
01ae495
fix test
pro-nsk Jul 31, 2023
93cb079
fix test
pro-nsk Jul 31, 2023
7173641
add audio support
pro-nsk Aug 9, 2023
8c23bfe
Merge branch 'master' of github.com:prebid/prebid-server-java into pr…
pro-nsk Aug 9, 2023
a77937a
Merge branch 'prebid-master'
pro-nsk Aug 9, 2023
47eccb9
fix test
pro-nsk Aug 9, 2023
b05ae38
Merge pull request #9 from prebid/master
pro-nsk Aug 24, 2023
1a20500
Merge pull request #10 from prebid/master
pro-nsk Sep 7, 2023
c6958e2
Resolve Auction_PRICE macro issue
kalidas-alkimi Sep 7, 2023
4132890
auction_price macro test
pro-nsk Sep 11, 2023
a207720
auction_price macro test: fix
pro-nsk Sep 11, 2023
b162de8
auction_price macro test: fix
pro-nsk Sep 11, 2023
789663a
auction_price macro test: fix
pro-nsk Sep 11, 2023
8105cf3
Merge pull request #11 from prebid/master
pro-nsk Oct 11, 2023
2bfd9d2
Merge pull request #12 from prebid/master
pro-nsk Jan 16, 2024
926ce2e
Added user sync URK for alkimi bidder adapter
kalidas-alkimi Jan 16, 2024
63dee8e
Merge pull request #29 from prebid/master
pro-nsk Feb 6, 2025
7185553
Added support for Imp extention object
kalidas-alkimi Feb 11, 2025
2468f4c
Updated the test for adding token id
kalidas-alkimi Feb 12, 2025
f829054
Added the unit test cases
kalidas-alkimi Feb 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,16 @@ private ExtImpAlkimi parseImpExt(Imp imp) {
private Imp updateImp(Imp imp, ExtImpAlkimi extImpAlkimi) {
final Price bidFloorPrice = Price.of(imp.getBidfloorcur(), imp.getBidfloor());

final ObjectNode newExt = imp.getExt().deepCopy();
newExt.replace("bidder", makeImpExt(imp, extImpAlkimi));
Comment on lines +70 to +71
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add unit test that will check that other fields will be passed through


return imp.toBuilder()
.bidfloor(BidderUtil.isValidPrice(bidFloorPrice)
? bidFloorPrice.getValue()
: extImpAlkimi.getBidFloor())
.instl(extImpAlkimi.getInstl())
.exp(extImpAlkimi.getExp())
.ext(makeImpExt(imp, extImpAlkimi))
.ext(newExt)
.build();
}

Expand All @@ -82,7 +85,7 @@ private ObjectNode makeImpExt(Imp imp, ExtImpAlkimi extImpAlkimi) {

extBuilder.adUnitCode(imp.getId());

return mapper.mapper().valueToTree(ExtPrebid.of(null, extBuilder.build()));
return mapper.mapper().valueToTree(extBuilder.build());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
},
"bidfloor": 0.5,
"ext": {
"tid": "${json-unit.any-string}",
"bidder": {
"token": "XXX",
"bidFloor": 0.5,
Expand Down
Loading