Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot: Add possibility to have only one micro simulation object #123

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

tjwsch
Copy link
Collaborator

@tjwsch tjwsch commented Aug 8, 2024

Adds functionality to only create one micro simulation object in the snapshot computation if all micro simulations are initialized with the same configuration and no information is transferred from one solve call to another.
Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@tjwsch tjwsch added the enhancement Enchance existing functionality label Aug 8, 2024
@tjwsch tjwsch requested a review from IshaanDesai August 8, 2024 14:59
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 In what situations would this be useful? This could be something worth mentioning in the documentation (see the comment above).

CHANGELOG.md Outdated Show resolved Hide resolved
docs/snapshot_configuration.md Outdated Show resolved Hide resolved
micro_manager/config.py Outdated Show resolved Hide resolved
@tjwsch
Copy link
Collaborator Author

tjwsch commented Aug 12, 2024

I added a comment regarding when it is useful to apply this option

@IshaanDesai IshaanDesai merged commit 89f6a63 into develop Aug 13, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the add_initialize_once_option branch August 13, 2024 08:36
@IshaanDesai IshaanDesai mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enchance existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants