Release v0.4.0 #88
Merged
Release v0.4.0 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WIP] Update preCICE API calls * Changing mocked preCICE to v3 * Explicitly mention v3.0.0.0dev0 for pyprecice * Use correct API function get_mesh_vertex_ids_and_coordinates * Use pyprecice v3.0.0.0dev1 * Formatting * Work with pyprecice v3.0.0.0dev2 * Partially fixing tests * Fix tests * Formatting * Fix precice-configs * Move dimensions parameter back to precice-configuration * Move initialize after requires_initial_data() * Remove initialize() from micro simulations, along with the writing of initial data to preCICE * In time loop, get dt from preCICE * Make precice findable in Action, remove initialize() from pybind11 wrapper, other fixes * Port unit_cube.py to v3 * Port config used in adaptivity integration test * Port config to v3, remove use of su for parallel tests * Allow mpiexec to run as root for parallel tests, fix error in unit_cube.py for integration tests * Modify LD_LIBRARY_PATH in Action, fix unit_cube.py * Remove user precice in adaptivity parallel tests * Use correct container and proper working directories in Actions * Move dimensions attribute into mesh tag * Pass correct dt to read_data(...) command --------- Co-authored-by: Ishaan Desai <[email protected]>
* Clean up adaptivity tests * Rename long variables in micro_manager.py
* Fix typo * Add --config parameter to the run-micro-manager.py execution command * Add assertion to check if a rank has no vertices --------- Co-authored-by: Ishaan Desai <[email protected]>
…f adaptivity. (#75) * Warn if only micro-scale data is used in the similarity computation of adaptivity * Formatting * Reword warning * Formatting
* Make initialize() a private method * Remove calls to initialize()
… of micro simulations (#78) * Moving functionality relevant to global adaptivity into its own constructor rather than initialize() * Remove unnecessary declaration of internal variable in global adaptivity test * Add fix for a case where ranks have unequal number of micro simulations * Cleanup * Repair test
* Pass ID to micro simulations * Pass ID to micro simulation class constructors in dummies * Formatting * Pass the global ID in the state of the C++ micro simulation in the dummy * Fix C++ solver dummy * Remove function set_global_id from Simulation class, as we should never have to change the global ID of a micro simulation * Change documentation to add passing global id to simulation during defining
* Fix bugs in global adaptivity * Fix formatting and also a bug in the local adaptivity * Set coarse tolerance to sys.float_info.min if all the similarity distances are zero
…imulations on each rank in initialization (#81)
* Reintroduce initialize() function optionally in the micro simulation API, and use its data for adaptivity * Check if initialize() method exists, and if yes, run it * Check is_sim_active * Remove print statement * Use dict given by initialize() as it is * Rewrite documentation in parallel tests * Set initialization condition for not one just all ranks * Formatting
Co-authored-by: Torben Schiz <[email protected]>
* Use nightly image of precice/precice and be consistent across workflows for installation commands * Remove unfinished test coverage CI
…no good way to pass the sim id to the new micro simulation instance
IshaanDesai
force-pushed
the
micro-manager-v0.4.0
branch
from
fa7770f to
f49c04b
Compare
Fujikawas
approved these changes
Mar 21, 2024
IshaanDesai
force-pushed
the
micro-manager-v0.4.0
branch
from
f49c04b to
02bb42d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release includes:
initialize()from the micro simulation API commitinitialize()method of the MicroManager class private Makeinitialize()a private method #77precice:develop#51