feat: paper feedback

.hydra/default.nix

@@ -1,4 +1,5 @@
-{ declInput, projectName, ... }: let
+{ declInput, projectName, ... }:
+let
   jobsets = {
     flakeJobset = {
       enabled = 1;
@@ -11,10 +12,11 @@
       enableemail = false;
       emailoverride = "";
       keepnr = 3;
-      inputs = {};
+      inputs = { };
     };
   };
-in {
+in
+{
   jobsets = derivation {
     name = "forschungsprojekt-spec.json";
     system = builtins.currentSystem;

.hydra/release.nix

@@ -12,20 +12,27 @@ let
   names = builtins.attrNames ((builtins.elemAt precicePkgs 1) { } { });
 
   # Generate attrs in form `packagename = pkgs.packagename;`
-  packages = builtins.listToAttrs (builtins.map (name: { inherit name; value = pkgs."${name}"; }) names);
+  packages = builtins.listToAttrs (
+    builtins.map (name: {
+      inherit name;
+      value = pkgs."${name}";
+    }) names
+  );
 
   # $ NIXOS_CONFIG=$PWD/configuration.nix nix repl '<nixpkgs/nixos>'
   # nix-repl> config.system.build.vm
   # vm = (pkgs.nixos { configuration}).config.system.build.vm
-  inherit ((import <nixpkgs/nixos/lib/eval-config.nix> {
-    modules = [
-      ../configuration.nix
-      {
-        nixpkgs.pkgs = pkgs;
-      }
-    ];
-  }).config.system.build) vm;
+  inherit
+    ((import <nixpkgs/nixos/lib/eval-config.nix> {
+      modules = [
+        ../configuration.nix
+        { nixpkgs.pkgs = pkgs; }
+      ];
+    }).config.system.build
+    )
+    vm
+    ;
 
 in
-  # These are the separate jobs that are generated
-  packages // { inherit vm; }
+# These are the separate jobs that are generated
+packages // { inherit vm; }

paper/LICENSE

@@ -0,0 +1,22 @@
+MIT License
+
+Copyright (c) 2024 preCICE
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+

paper/paper.bib

@@ -10,7 +10,7 @@ @techreport{studentreport
     title={Improving reproducibility of scientific software using Nix/NixOS},
     author={Max Hausch and Simon Hauser},
     year={2023},
-    url={https://github.com/precice/nix-packages/releases/download/initial-paper-release/hauser-hausch-research-paper-cb56c9362bf1a2bd1b18873dd36c05b5a082097c.pdf},
+    url={https://github.com/precice/nix-packages/releases/tag/initial-paper-release},
     institution = {University of Stuttgart}
 }
 @article{Dalle_2012,

precice-packages/precice-fenics-adapter/default.nix

@@ -1,6 +1,6 @@
 {
   lib,
-  fetchPypi,
+  fetchFromGitHub,
   python3,
   precice,
   fenics,
@@ -14,10 +14,11 @@ python3.pkgs.buildPythonPackage rec {
   pname = "precice-fenics-adapter";
   version = "1.4.0";
 
-  src = fetchPypi {
-    pname = "fenicsprecice";
-    inherit version;
-    hash = "sha256-ux5qi4SGGHETbldfEiT8H/7Pvmn2uvQwDFB1wi/pAKI=";
+  src = fetchFromGitHub {
+    owner = "precice";
+    repo = "fenics-adapter";
+    rev = "v${version}";
+    hash = "sha256-tddOcFZ/ls6fV+prtHQSIJmJ04eU9voj7ZyXEzEU6fA=";
   };
 
   nativeBuildInputs = [
@@ -33,10 +34,8 @@ python3.pkgs.buildPythonPackage rec {
     fenics-mshr
     python3.pkgs.scipy
   ];
-  checkInputs = with python3.pkgs; [ pytest ];
-
-  # TODO(conni2461): Remove once (two tests still fail
-  doCheck = false;
+  pythonImportsCheck = [ "fenicsprecice" ];
+  nativeCheckInputs = with python3.pkgs; [ pytest ];
 
   DIJITSO_CACHE_DIR = "/tmp";