Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev docs page on naming conventions #424

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Jul 8, 2024

Explaining why packages and other things are named the way they are.

I have not tested if the website builds and how it renders.

@MakisH MakisH self-assigned this Jul 8, 2024
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally ok, but let's do another iteration on the comments and discuss open points in person.

pages/docs/dev-docs/dev-naming.md Outdated Show resolved Hide resolved
pages/docs/dev-docs/dev-naming.md Outdated Show resolved Hide resolved
pages/docs/dev-docs/dev-naming.md Outdated Show resolved Hide resolved
pages/docs/dev-docs/dev-naming.md Outdated Show resolved Hide resolved
pages/docs/dev-docs/dev-naming.md Show resolved Hide resolved
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the open comments, good to go for me.

pages/docs/dev-docs/dev-naming.md Show resolved Hide resolved
@MakisH MakisH merged commit 3a80e1b into precice:master Jul 15, 2024
2 checks passed
@MakisH MakisH deleted the docs-naming branch July 15, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants