Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #554 and require fenicsadapter 2.2.0 to fix subcycling #578

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

NiklasVin
Copy link
Collaborator

@NiklasVin NiklasVin commented Oct 22, 2024

This resolves #573 by reverting #554.
For more information, refer to #573.

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing the changes now. Without subcycling, sold-dealii and solid-fenics are in good agreement. When I perform subcycling as described in precice/fenics-adapter#172 I also get the errors we have seen there.

As a solution we have to do the following:

I will take care of these steps.

I'm currently performing some tests with the pre-release v2.2.0rc1 and subcycling and the results look good.

@BenjaminRodenberg BenjaminRodenberg changed the title Revert changes of #554 Revert #554 and require fenicsadapter 2.2.0 to fix subcycling Oct 25, 2024
BenjaminRodenberg added a commit to BenjaminRodenberg/tutorials that referenced this pull request Oct 25, 2024
@BenjaminRodenberg
Copy link
Member

@MakisH can you run the systemtests using this branch? This should work now if the systemtest pick up fenicsprecice 2.2.0 correctly.

@MakisH
Copy link
Member

MakisH commented Nov 4, 2024

Hm, actually, no: we have a limitation at the system tests at the moment, that we cannot check out commits from forks (opened an issue: #580). If the commit was in this branch, the command to trigger the system tests would have been:

gh workflow run run_testsuite_manual.yml -f suites=release_test -f build_args="PRECICE_REF:v3.1.2,OPENFOAM_ADAPTER_REF:v1.3.1,PYTHON_BINDINGS_REF:v3.1.2,FENICS_ADAPTER_REF:v2.2.0,SU2_VERSION:7.5.1,SU2_ADAPTER_REF:64d4aff,TUTORIALS_REF:53fea5c" --ref=develop

(yes this can be simplified similarly to other repositories, opened an issue #581)

I suggest merging if you know that this is something ready to be merged and then re-check on develop.

@BenjaminRodenberg
Copy link
Member

I did a final round of testing similar to the ones in #573:

image

Results look good and we are back on track 👍 I will merge this PR now.

@BenjaminRodenberg BenjaminRodenberg merged commit a10e4a6 into precice:develop Nov 7, 2024
1 check passed
@BenjaminRodenberg
Copy link
Member

@MakisH systemtests should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perpendicular-flap/solid-fenics: Regression
3 participants