Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial flow-over-plate Code_Aster-OpenFOAM #74

Merged
merged 9 commits into from
Mar 27, 2020
Merged

Conversation

micheltakken
Copy link
Contributor

Move the flow-over-plate tutorial for coupling Code_Aster and OpenFOAM from the Code_Aster-adapter repository to the tutorials repository

@micheltakken micheltakken requested a review from MakisH March 20, 2020 09:05
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes to consider. Everything else discussed in precice/code_aster-adapter#6 seems to be good already.

After fixing these, I will also try to run everything once again.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tutorial runs smoothly, we just need to explicitly set the exchange-dir right now. But I will have look on this separately and add a note in the wiki.

I also see that we don't need the config.yml anymore. Feel free to remove this file and merge.

@MakisH MakisH merged commit 74a401e into develop Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants