-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stella embeddings + Integration tests for lorax #668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Why the name integration-tests-2
, maybe we just need to rename integration-tests
to something more meaningful? Can be a follow-up.
from utils.docker_runner import run_lorax_container | ||
|
||
|
||
def test_base_mistral(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be fun to make data-driven using pytest.mark.parametrize
in a follow-up :)
But good for v1.
No description provided.