Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stella embeddings + Integration tests for lorax #668

Merged
merged 67 commits into from
Nov 12, 2024

Conversation

magdyksaleh
Copy link
Collaborator

No description provided.

@magdyksaleh magdyksaleh marked this pull request as draft November 8, 2024 10:06
@magdyksaleh magdyksaleh changed the title Integration tests for lorax Fix stella embeddings + Integration tests for lorax Nov 8, 2024
Copy link
Contributor

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Why the name integration-tests-2, maybe we just need to rename integration-tests to something more meaningful? Can be a follow-up.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
from utils.docker_runner import run_lorax_container


def test_base_mistral():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fun to make data-driven using pytest.mark.parametrize in a follow-up :)

But good for v1.

integration-tests-2/utils/docker_runner.py Outdated Show resolved Hide resolved
@magdyksaleh magdyksaleh merged commit 429520c into main Nov 12, 2024
1 check passed
@magdyksaleh magdyksaleh deleted the integration-tests-main branch November 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants