Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return requests.Response instead of bool for verbose debugging #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Return requests.Response instead of bool for verbose debugging #1

wants to merge 3 commits into from

Conversation

pimoens
Copy link

@pimoens pimoens commented May 5, 2023

Instead of returning a boolean after requests with the Web Thing, return the full response. Makes it easier to debug when something goes wrong.

@pimoens pimoens requested a review from epadman May 5, 2023 12:27
epadman
epadman requested changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@epadman epadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are problems with moving StompWebsocket initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epadman epadman epadman requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@pimoens pimoens

@epadman epadman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pimoens @epadman