chore(cosmetic): de-uppercase form labels

Recent design proposals point towards removing the uppercase usage across the board, and this PR starts the process with form labels. it builds upon apache#24736 that started to address hierarchy-is-unclear issue in Explore control panel and makes things a bit neater on top of it.
preset-io · Jul 19, 2023 · 495f22e · 495f22e
1 parent 59d393c
commit 495f22e
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 6 deletions.
diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/components/ControlForm/index.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/components/ControlForm/index.tsx
@@ -123,7 +123,6 @@ export default function ControlForm({
     <div
       css={{
         label: {
-          textTransform: 'uppercase',
           color: theme.colors.text.label,
           fontSize: theme.typography.sizes.s,
         },

diff --git a/superset-frontend/src/assets/stylesheets/less/cosmo/bootswatch.less b/superset-frontend/src/assets/stylesheets/less/cosmo/bootswatch.less
@@ -508,7 +508,6 @@ a {
 }
 
 .control-label {
-  text-transform: uppercase;
   color: @gray;
   font-size: @font-size-s;
 }
diff --git a/superset-frontend/src/components/Form/FormItem.tsx b/superset-frontend/src/components/Form/FormItem.tsx
@@ -24,7 +24,6 @@ const StyledItem = styled(Form.Item)`
     .ant-form-item-label {
       padding-bottom: ${theme.gridUnit}px;
       & > label {
-        text-transform: uppercase;
         font-size: ${theme.typography.sizes.s}px;
         color: ${theme.colors.grayscale.base};
 

diff --git a/superset-frontend/src/components/Form/FormLabel.tsx b/superset-frontend/src/components/Form/FormLabel.tsx
@@ -27,14 +27,12 @@ export type FormLabelProps = {
 };
 
 const Label = styled.label`
-  text-transform: uppercase;
   font-size: ${({ theme }) => theme.typography.sizes.s}px;
   color: ${({ theme }) => theme.colors.grayscale.base};
   margin-bottom: ${({ theme }) => theme.gridUnit}px;
 `;
 
 const RequiredLabel = styled.label`
-  text-transform: uppercase;
   font-size: ${({ theme }) => theme.typography.sizes.s}px;
   color: ${({ theme }) => theme.colors.grayscale.base};
   margin-bottom: ${({ theme }) => theme.gridUnit}px;

diff --git a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
@@ -83,7 +83,6 @@ const ContentStyleWrapper = styled.div`
       font-weight: ${theme.typography.weights.medium};
       color: ${theme.colors.grayscale.light2};
       line-height: 16px;
-      text-transform: uppercase;
       margin: 8px 0;
     }