Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default value parameter to hook #224

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

fdalcin
Copy link
Contributor

@fdalcin fdalcin commented Jan 2, 2025

Issue pressbooks/pressbooks-lti#232. Accompanies pressbooks/pressbooks-lti#251.

This PR adds an additional parameter to the hook which is used as the default value in scenarios where the hook is not set at runtime.

Copy link
Contributor

@arzola arzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arzola arzola merged commit c8e5c68 into dev Jan 2, 2025
@arzola arzola deleted the fix/add-default-value-parameter branch January 2, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants