This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Use $NETCDF_HOME instead of harcoded paths on linux #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current netcdf_include and netcdf_lib paths are hardcoded, and don't work on most linux installs. I changed setup.py to look for the $NETCDF_HOME variable, which should point to the netCDF4 install directory. If $NETCDF_HOME is not set, current hardcoded directory will be used instead. Added note to install doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified
setup.pyto look for the netcdf4 directory in the environment variable$NETCDF_HOME. If the environment variable does not exist, it will default back to the original hardcoded paths.I did this for both the "Caltech" and "Linux" config sections, because when I configure pycles on my linux machines, they always use the "Caltech" config section because the check for that machine is pretty general ('x86_64' and 'LD_LIBRARY_PATH' are pretty general, and would exist on most compute clusters).