feat(presto-client): return back the whole error object #17
Conversation
jorgeramirezamora
changed the title
|
Good idea @jorgeramirezamora , I'll include an example of using the returned error 👍 |
|
I believe the error handling is deviating from the documentation. But the doc update could come later :-) LGTM |
|
I created an interface for PrestoError but I'm now thinking that it should be a class, so that you can do catch (error) {
if (error instanceof PrestoError) { ... }
}so I'll take some time to refactor that |
| if (error instanceof PrestoError) { | ||
| /* eslint-disable no-console */ | ||
| // The error here contains all the information returned by Presto directly | ||
| console.info(error.message) | ||
| console.info(error.name) | ||
| console.info(error.errorCode) | ||
| console.info(error.stack) | ||
| console.info(error.failureInfo.type) | ||
| return 'A Presto error ocurred, please check the service logs' |
There was a problem hiding this comment.
I added this example usage in the app to better showcase how to use the returned error
| try { | ||
| return await this.appService.getDataWithError() | ||
| } catch (err) { | ||
| console.error(err) |
There was a problem hiding this comment.
I guess this would be an error other than PrestoError because the PrestoError is handled in the getDataWithError and no rethrow.
There was a problem hiding this comment.
yeah, I guess I'm using the service file as the showcase for the error
I don't know if we should also do something else here in the controller
| const prestoQuery = await client.query(query) | ||
| const results = prestoQuery.data | ||
| } catch (error) { | ||
| if (error instanceof PrestoError) { |
Changes
Resolves #11